FC-0057: add makefile command for black formatting#32
Merged
Faraz32123 merged 4 commits intomasterfrom Aug 15, 2024
Merged
Conversation
Faraz32123
changed the title
Faraz32123
force-pushed
the
feat/add_makefile_command_for_black
branch
from
1b0e7d3 to
7c90c91
Compare
regisb
suggested changes
Aug 15, 2024
- `make test-format` command view the files under forum/ tests/ test_utils/ directories that needs formatting - `make format` command format all files under forum/ tests/ test_utils/ directories - add black to dev requirements
Faraz32123
force-pushed
the
feat/add_makefile_command_for_black
branch
from
7c90c91 to
3cf1fb9
Compare
Faraz32123
force-pushed
the
feat/add_makefile_command_for_black
branch
from
2360c71 to
a4cc093
Compare
Contributor
Author
|
I haven't added black in requirements yet, that's why tests are failing. |
regisb
reviewed
Aug 15, 2024
- include black in requirements - upgrade requirements with python 3.11
Faraz32123
force-pushed
the
feat/add_makefile_command_for_black
branch
from
b1ed816 to
d5f612e
Compare
- remove isort from quality checks as it should be optional if someone wants to check it locally - formatted the remaining file with black that had a conflict with isort
taimoor-ahmed-1
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make test-formatcommand view the files under forum/ tests/ test_utils/ directories that needs formattingmake formatcommand format all files under forum/ tests/ test_utils/ directories