Conversation
The make and tox targets that ship with the cookiecutter are a real mess. Here, we reorganise these targets as follows: - tox depends on make commands - make commands do not depend on tox - make commands are more granular, and faster to run. In addition, requirement files are reorganised to avoid circular dependencies and duplicate requirements. Because mypy checks are now run as part of "tox -e quality", we no longer need the mypy github action. Moreover, we introduce the compile-requirements make target, which is useful for compiling requirements without upgrading them. We removed the diff_cover make target, which wasn't working anyway because it defaulted to "--compare-branch=main", and the "main" branch does not exist.
regisb
force-pushed
the
regisb/better-tox-makefile
branch
from
120aef6 to
9e747e0
Compare
taimoor-ahmed-1
approved these changes
Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The make and tox targets that ship with the cookiecutter are a real mess. Here, we reorganise these targets as follows:
In addition, requirement files are reorganised to avoid circular dependencies and duplicate requirements.
Because mypy checks are now run as part of "tox -e quality", we no longer need the mypy github action.
Moreover, we introduce the compile-requirements make target, which is useful for compiling requirements without upgrading them.
We removed the diff_cover make target, which wasn't working anyway because it defaulted to "--compare-branch=main", and the "main" branch does not exist.