Skip to content

FC-0057: implement pin/unpin APIs#36

Merged
Faraz32123 merged 3 commits intomasterfrom
feat/add_pin_unpin_apis_and_its_tests
Aug 15, 2024
Merged

FC-0057: implement pin/unpin APIs#36
Faraz32123 merged 3 commits intomasterfrom
feat/add_pin_unpin_apis_and_its_tests

Conversation

@Faraz32123
Copy link
Copy Markdown
Contributor

Muhammad Faraz Maqsood added 2 commits August 14, 2024 00:02
- merge this PR for now and create a separate issue for the tests of pin/unpin APIs
@Faraz32123 Faraz32123 force-pushed the feat/add_pin_unpin_apis_and_its_tests branch from 3cd8a72 to d398ea9 Compare August 15, 2024 12:52
@Faraz32123
Copy link
Copy Markdown
Contributor Author

created a separate issue for pin/unpin APIs tests.
https://github.com/edly-io/forum/issues/40

@Faraz32123 Faraz32123 changed the title feat: add pin/unpin APIs and it's tests feat: implement pin/unpin APIs Aug 15, 2024
@Faraz32123 Faraz32123 changed the title feat: implement pin/unpin APIs FC-0057: implement pin/unpin APIs Aug 15, 2024
Comment thread forum/utils.py Outdated
Copy link
Copy Markdown
Contributor

@Ali-Salman29 Ali-Salman29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this empty file tests/test_views/test_pins.py.

- moved mongo related code to a single file that was being used
- removed empty files
Copy link
Copy Markdown
Contributor

@taimoor-ahmed-1 taimoor-ahmed-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Faraz32123 Faraz32123 merged commit 295844a into master Aug 15, 2024
@Faraz32123 Faraz32123 deleted the feat/add_pin_unpin_apis_and_its_tests branch August 15, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate the /pins API endpoints

3 participants