chore: greatly simplify mocking and models API#39
Merged
Conversation
regisb
force-pushed
the
regisb/mocking
branch
2 times, most recently
from
3e669fc to
7823d7a
Compare
The MongoBackend now provides access only to a database, and it is the responsibility of each child model to access the collection. This is done transparently via the _collection property. The MongoBackend constructor was also simplified. Because we are now using a single database object, we can drastically simplify mocking in tests. That's because we don't have to mock models one by one. And it turns out that we don't need to store the client attribute. Neither do we need to store a diffent collection name for every model instance, so we can simply store it as a class attribute. This means that we no longer need constructors for models.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We split the ModelBackend in database/collection. This means that we can override the database globally in unit tests. This also drastically simplifies model constructors.