chore: get rid of type/pylint ignore statements#41
Merged
Conversation
regisb
force-pushed
the
regisb/type-ignores
branch
2 times, most recently
from
9185dd1 to
c4b5f3d
Compare
regisb
force-pushed
the
regisb/type-ignores
branch
from
c4b5f3d to
9966dc8
Compare
Faraz32123
reviewed
Aug 15, 2024
1. Child model classes inherited the insert and update methods, but with a different signature. This violated the Liskov principle, which is explained here: https://stackoverflow.com/a/54359797/356528 To bypass this, we migrated most of the Content class to a separate base class, and insert/update methods are no longer inherited. 2. We removed type ignores in serializers, which were simply missing a generic type definition. 3. We also updated the APIClient, but we failed to properly type it, because we don't know how to use "_MonkeyPatchedWSGIResponse".
regisb
force-pushed
the
regisb/type-ignores
branch
from
9966dc8 to
1be488e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Child model classes inherited the insert and update methods, but with a different signature. This violated the Liskov principle, which is explained here: https://stackoverflow.com/a/54359797/356528 To bypass this, we migrated most of the Content class to a separate base class, and insert/update methods are no longer inherited.
We removed type ignores in serializers, which were simply missing a generic type definition.
We also updated the APIClient, but we failed to properly type it, because we don't know how to use "_MonkeyPatchedWSGIResponse".