FC-0057: implement comment APIs#52
Merged
Faraz32123 merged 10 commits intomasterfrom Aug 21, 2024
Merged
Conversation
- these call are implemented:
/comments/:comment_id DELETE (deletes parent/child comment)
/comments/:comment_id GET (get parent comment)
/comments/:comment_id POST (created child comment)
/comments/:comment_id PUT (updates parent/child comment)
Faraz32123
changed the title
added 4 commits
August 20, 2024 11:54
- handle child_count of parent comment in case of child comment deletion - simplify code and use one serializer
- resolved quality checks - fixed Comments models insert method definition
Faraz32123
requested review from
Ali-Salman29 and
taimoor-ahmed-1
and removed request for
Ali-Salman29
Contributor
Author
|
Tests are failing after merging the code from master, i'll update my code accordingly to make tests pass and will turn the PR ready for review again. |
taimoor-ahmed-1
requested changes
Aug 20, 2024
- make changes to the previous comments serializers - resolved comments - fixed adding childs count if it was zero before
Ali-Salman29
approved these changes
Aug 20, 2024
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These below calls are implemented:
This API(
get "#{APIPREFIX}/comments" do) isn't being used in frontend.close #37