chore: refactor serializers#63
Merged
Faraz32123 merged 1 commit intomasterfrom Aug 23, 2024
Merged
Conversation
Faraz32123
force-pushed
the
chore/serializers_refactorization
branch
from
c6c289d to
831691f
Compare
Contributor
|
LGTM! |
Ali-Salman29
approved these changes
Aug 23, 2024
Faraz32123
force-pushed
the
chore/serializers_refactorization
branch
2 times, most recently
from
8c875a5 to
ecdddee
Compare
- refactored serializers, now there's only one serializer for comment and thread and both inherits a single content serializer. - Also tried overriding is_valid() method of serializer but mypy and pylint were conflicting together. - rename serializers
Faraz32123
force-pushed
the
chore/serializers_refactorization
branch
from
ecdddee to
d8f269c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR: