FC-0057: initiate openedx forum django app#7
Merged
Faraz32123 merged 3 commits intomasterfrom Jul 26, 2024
Merged
Conversation
initiated openedx forum django app using edx-cookiecutters https://github.com/openedx/edx-cookiecutters
Faraz32123
changed the title
Faraz32123
force-pushed
the
feat/initiate_openedx_forum_django_app
branch
from
d948ea9 to
8ea0c30
Compare
github workflows were failing due to - ci.txt and dev.txt did not exist - tox command does not exits
Faraz32123
force-pushed
the
feat/initiate_openedx_forum_django_app
branch
from
8ea0c30 to
07fe4e2
Compare
Faraz32123
force-pushed
the
feat/initiate_openedx_forum_django_app
branch
from
e80a20c to
56ad0af
Compare
- use codecov actions without CODECOV_TOKEN as its a public repository - set fail_ci_if_error flag to False - format forum/__init__.py
Faraz32123
force-pushed
the
feat/initiate_openedx_forum_django_app
branch
from
56ad0af to
dc0ae67
Compare
regisb
approved these changes
Jul 26, 2024
Contributor
regisb
left a comment
regisb
left a comment
There was a problem hiding this comment.
There's a whole lot of code to change or remove, but otherwise this LGTM :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close Setup the forum app using the edx-cookiecutter #1