Skip to content

FC-0057: add a thin proxy API btw LMS and v1#8

Merged
Faraz32123 merged 1 commit intomasterfrom
feat/add_thin_proxy_btw_lms_and_v1_app
Aug 1, 2024
Merged

FC-0057: add a thin proxy API btw LMS and v1#8
Faraz32123 merged 1 commit intomasterfrom
feat/add_thin_proxy_btw_lms_and_v1_app

Conversation

@Faraz32123
Copy link
Copy Markdown
Contributor

@Faraz32123 Faraz32123 commented Jul 29, 2024

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Comment thread forum/api/v1/views.py Outdated
@Faraz32123 Faraz32123 force-pushed the feat/add_thin_proxy_btw_lms_and_v1_app branch from 2aa7ca0 to 1c66afa Compare July 30, 2024 19:28
@Faraz32123 Faraz32123 changed the title feat: add a thin proxy API btw LMS and v1 FC-0057: add a thin proxy API btw LMS and v1 Jul 31, 2024
Comment thread forum/api/v1/views.py Outdated
@Faraz32123 Faraz32123 force-pushed the feat/add_thin_proxy_btw_lms_and_v1_app branch from 1c66afa to 3bc0342 Compare July 31, 2024 07:21
Comment thread forum/api/v1/views.py Outdated
@Faraz32123 Faraz32123 force-pushed the feat/add_thin_proxy_btw_lms_and_v1_app branch from 3bc0342 to f74d0a5 Compare July 31, 2024 12:01
@Faraz32123 Faraz32123 marked this pull request as ready for review July 31, 2024 12:08
Comment thread forum/views.py Outdated
@Faraz32123 Faraz32123 force-pushed the feat/add_thin_proxy_btw_lms_and_v1_app branch from f74d0a5 to e266c42 Compare July 31, 2024 12:57
Copy link
Copy Markdown
Contributor

@taimoor-ahmed-1 taimoor-ahmed-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Faraz32123 Faraz32123 force-pushed the feat/add_thin_proxy_btw_lms_and_v1_app branch 12 times, most recently from fb83cdf to e026dce Compare July 31, 2024 15:55
- Add apps.py and entry points for the app to be detected by LMS
- create a thin proxy API, this api will act as a middleware.
  edx-platdorm will call this api instead of forum v1 and this
  thin proxy api will call forum v1 APIs.
- implement get, post, put, delete mathods
- add sample curl requests
- resolve CI checks, made use of default packages instead of openedx imports
  added `requests` and `djangorestframework` packages to requirements and upgraded requirements
- remove django32 CI checks, upgrade django40 CI check to django42
- modify pylint rules
- address some pylint issues
@Faraz32123 Faraz32123 force-pushed the feat/add_thin_proxy_btw_lms_and_v1_app branch from e026dce to 2aa76b8 Compare July 31, 2024 15:57
@Faraz32123 Faraz32123 merged commit f301a35 into master Aug 1, 2024
@Faraz32123 Faraz32123 deleted the feat/add_thin_proxy_btw_lms_and_v1_app branch August 1, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement a thin proxy between the LMS and the v1 app

3 participants