fix: differences in forum v1 and v2 get responses#83
Merged
Faraz32123 merged 2 commits intomasterfrom Sep 10, 2024
Merged
Conversation
Contributor
Faraz32123
commented
Sep 10, 2024
Faraz32123
commented
- fix the response of get thread API according to query params when thread type is question
- fix the response of get thread API when answered question is marked back as not answered when thread type is question.
- fix the response of user's subscribed thread API as it wasn't deleting the subscriptions of the thread when thread was deleted, and was returning more subscribed threads in the response
- add tests for the above cases
- close On a live instance of Open edX, make sure that all calls go to v2 (and are consistent with v1 responses) #47
- fix the response of get thread API according to query params when thread type is question - fix the response of get thread API when answered question is marked back as not answered when thread type is question. - fix the response of user's subscribed thread API as it wasn't deleting the subscriptions of the thread when thread was deleted, and was returning more subscribed threads in the response - add tests for the above cases - close #47
Faraz32123
requested review from
Ali-Salman29 and
taimoor-ahmed-1
and removed request for
taimoor-ahmed-1
Ali-Salman29
approved these changes
Sep 10, 2024
Faraz32123
force-pushed
the
fix/differences_in_forum_v1_and_v2
branch
from
d4f0429 to
afd8a7c
Compare
- return abuse_count_flag in get_threads - pop historical_abuse_flaggers from comment and thread serializer
regisb
reviewed
Sep 11, 2024
| "merge_question_type_responses", | ||
| ] | ||
| for param in params: | ||
| if param in data_or_params: |
Contributor
There was a problem hiding this comment.
if value := data_or_params.get(param):
context[param] = str_to_bool(value)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.