chore: remove Any(collection) from str_to_bool function#92
Merged
Faraz32123 merged 1 commit intomasterfrom Sep 12, 2024
Merged
Conversation
Contributor
Faraz32123
commented
Sep 12, 2024
Faraz32123
commented
- remove Any(collection) from str_to_bool function's argument type definition.
Ali-Salman29
approved these changes
Sep 12, 2024
regisb
reviewed
Sep 13, 2024
| for param in params: | ||
| if param in data_or_params: | ||
| context[param] = str_to_bool(data_or_params.get(param)) | ||
| if value := data_or_params.get(param): |
Contributor
There was a problem hiding this comment.
🤔 we are not going to enter the if condition if the return value is boolean False. Is this what we want?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.