feat: make it easier to integrate with edx-platform#93
Merged
Conversation
With these changes, it is no longer necessary to fork edx-platform to interact with our custom app. - More streamlined mongodb/elasticsearch settings that are more compatible with edx-platform settings. - Refactored mongodb client for better reusability of settings. - Refactored ES classes for simpler client usage, and less leaky abstractions. - Added forum/api/v1 urls such that the forum app can be used without changes to edx-platform.
regisb
requested review from
Ali-Salman29,
Faraz32123 and
taimoor-ahmed-1
and removed request for
Faraz32123
Ali-Salman29
approved these changes
Sep 12, 2024
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes, it is no longer necessary to fork edx-platform to interact with our custom app.