-
Notifications
You must be signed in to change notification settings - Fork 4
Table cells refactor to get rid of eslint nested components ignore #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table cells refactor to get rid of eslint nested components ignore #31
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #31 +/- ##
==========================================
+ Coverage 94.32% 94.43% +0.11%
==========================================
Files 44 45 +1
Lines 881 899 +18
Branches 176 156 -20
==========================================
+ Hits 831 849 +18
Misses 48 48
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arbrandes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks correct to me. Thanks!
Description
This PR introduces a refactor on how the table cells components are declared in order to remove the eslint rule ignore for
react/no-unstable-nested-components. The existing Table Cells and new Table Cells components were moved to a new file and the corresponding testing file was created.Note
Considering the Table Cells components are small, all of them (currently 4) were moved to the same
.tsxfile, I am open to suggestions if each of the component should have its own file.It closes #22
How to test it
npm install && npm run devhttp://apps.local.openedx.io:2025/admin-console/authz/libraries/<YOUR_LIB_ID>