Skip to content

Conversation

@awais-ansari
Copy link
Contributor

@awais-ansari awais-ansari commented Nov 6, 2023

INF-1090

Description
I noticed in Hotjar recordings that the “Load more posts” button is very slow and gets even slower with successive clicks. I’ve attached a recording of a test I conducted.

Implementation

  • Component is optimized and every Post item is rendered one time.
  • The post item component was using the Truncate component to truncate the post title and preview. Which was taking too much time.
  • Our use cases are simple. So truncated the post title and preview using Bootstrap classes.
Screenshot 2023-11-06 at 9 55 07 PM

https://www.loom.com/share/4453d72e480243888de2a89cf206ce8f?sid=4f0da169-c032-4f40-99f5-ae6800f6b7aa

@awais-ansari awais-ansari force-pushed the aansari/list-loading-issue branch from 18a89a2 to 47e1477 Compare November 6, 2023 17:00
@codecov
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7d7221b) 92.32% compared to head (47e1477) 92.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #602      +/-   ##
==========================================
+ Coverage   92.32%   92.37%   +0.05%     
==========================================
  Files         169      169              
  Lines        3451     3450       -1     
  Branches      899      898       -1     
==========================================
+ Hits         3186     3187       +1     
+ Misses        244      243       -1     
+ Partials       21       20       -1     
Files Coverage Δ
src/discussions/posts/post/PostLink.jsx 96.77% <85.71%> (+6.14%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awais-ansari awais-ansari merged commit bcb43df into master Nov 7, 2023
@awais-ansari awais-ansari deleted the aansari/list-loading-issue branch November 7, 2023 06:48
@awais-ansari awais-ansari restored the aansari/list-loading-issue branch November 29, 2023 14:10
@awais-ansari awais-ansari deleted the aansari/list-loading-issue branch November 29, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants