-
Notifications
You must be signed in to change notification settings - Fork 6
Adding section on Data Downloads for Pending Tasks #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adding section on Data Downloads for Pending Tasks #74
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 0.00% 81.13% +81.13%
==========================================
Files 5 37 +32
Lines 7 318 +311
Branches 0 63 +63
==========================================
+ Hits 0 258 +258
- Misses 7 60 +53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
557f88d to
d475d43
Compare
|
can you rebase your PR against main pls? |
d475d43 to
65129d3
Compare
65129d3 to
6a754c6
Compare
|
Hi @jacobo-dominguez-wgu and @diana-villalvazo-wgu! Is this still in progress? |
| @@ -0,0 +1,101 @@ | |||
| import { screen, waitFor } from '@testing-library/react'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we have a typo here - this file should be PendingTasks.test.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIxed
src/components/ObjectCell.tsx
Outdated
| const ObjectCell = ({ value }: ObjectCellProps) => { | ||
| return ( | ||
| <pre style={{ whiteSpace: 'pre-wrap', wordBreak: 'break-word' }}> | ||
| {parseObject(value ?? '')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing empty string as fallback for null object seems odd - should this be parseObject(value ?? null) or parseObject(value ?? {})?
| import { useQuery, useMutation } from '@tanstack/react-query'; | ||
| import { getCourseInfo, fetchPendingTasks } from './api'; | ||
|
|
||
| export const usePendingTasks = (courseId: string) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider whether usePendingTasks might be better suited as a useQuery rather than useMutation - even though the endpoint incorrectly uses POST, it's semantically a read operation, which would give you automatic fetching, caching, and optional polling without needing the manual useEffect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to useQuery
wgu-jesse-stewart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great - good separation of concerns with dedicated components and hooks. Nice work. I just have a few suggestions and some questions.
- What's the polling/refresh strategy? Auto-refresh every X seconds?
- Should completed tasks eventually disappear from this list?
- Is there a maximum number of tasks displayed?
Thanks! |
Description
This pr adds the section of Pending Tasks into the Data Downloads Tab to display the ongoing report generation tasks, in case of no tasks in progress it displays a "No tasks currently running" message.
Supporting information
It needs to be reviewed after #68 since it includes part of the code from that pr.
Closes #44
Testing instructions
npm install && npm run devPOST
http://local.openedx.io:8000/courses/:courseId:/instructor/api/list_instructor_taskswith this response data:Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypes,defaultProps, andinjectIntlpatterns are not used in any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'