-
Notifications
You must be signed in to change notification settings - Fork 297
feat: Make courseware URLs more human-readable #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ormsbee
reviewed
Jul 15, 2021
ormsbee
reviewed
Jul 15, 2021
ormsbee
reviewed
Jul 15, 2021
ormsbee
reviewed
Jul 15, 2021
ormsbee
reviewed
Jul 15, 2021
ormsbee
reviewed
Jul 15, 2021
…arning into KristinAoki/TNL-8511
Contributor
|
I'm gonna close this PR - it's definitely not going to be merged after all this time. Would still be nice to see something like this done eventually though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the format of MFE URLs. Previously the URLs were extremely long and had repetitive information. This made it difficult for users to read and easily understand where they are within a course based on the URL. Now, the URL removes all the repetitive information and replaces it with a unique identifier. Updated all API call URLs with a decoded version of block id since unique identifier is being pulled from URL, but does not translate to any API in LMS.
This PR is connected to the edx-plarform PR-28174