fix: use request.url instead of global.location in authenticatedLoader#193
Open
arbrandes wants to merge 1 commit intoopenedx:mainfrom
Open
fix: use request.url instead of global.location in authenticatedLoader#193arbrandes wants to merge 1 commit intoopenedx:mainfrom
arbrandes wants to merge 1 commit intoopenedx:mainfrom
Conversation
During client-side navigation (e.g. via <Navigate>), React Router runs loaders before committing the new URL to the browser. This means global.location.pathname still reflects the previous page, causing the ?next= parameter to point to the wrong route. Use the request object that React Router passes to loaders instead, which always contains the correct destination URL. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During client-side navigation (e.g. via
<Navigate>), React Router runs loaders before committing the new URL to the browser. This meansglobal.location.pathnamestill reflects the previous page, causing the?next=parameter to point to the wrong route. Use the request object that React Router passes to loaders instead, which always contains the correct destination URL.LLM usage notice
Built with assistance from Claude models (mostly Opus 4.6).