Merged
Conversation
robrap
force-pushed
the
robrap/add-link-to-doc
branch
2 times, most recently
from
ff8de7b to
592c1cb
Compare
Add a link to the GitHub Pages site to the README.
robrap
force-pushed
the
robrap/add-link-to-doc
branch
from
592c1cb to
f3f89ff
Compare
davidjoy
approved these changes
May 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add a link to the GitHub Pages site to the README.
Merge checklist:
Consider running your code modifications in the included example app withinfrontend-platform. This can be done by runningnpm startand opening http://localhost:8080.Consider testing your code modifications in another local micro-frontend using local aliases configured via themodule.config.jsfile infrontend-build.fix,feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.Post merge:
After the build finishes for the merged commit, verify the new release has been pushed to NPM.