Skip to content

docs: add access token null docs#212

Merged
robrap merged 1 commit intomasterfrom
robrap/ARCHBOM-1150-token-null-after-refresh
Aug 18, 2021
Merged

docs: add access token null docs#212
robrap merged 1 commit intomasterfrom
robrap/ARCHBOM-1150-token-null-after-refresh

Conversation

@robrap
Copy link
Copy Markdown
Contributor

@robrap robrap commented Aug 17, 2021

Description:

Access token null after successful refresh is an
unexpected error that we haven't been able to solve.
This introduces an ADR-like document to document the
findings thus far, and the de-facto decision to leave
the bug unresolved.

ARCHBOM-1150

Author Concerns:

This is not the typical ADR, but I'm not sure the best type of document for notes that are too long for a code comment. If you have a different suggestion, let me know.

Access token null after successful refresh is an
unexpected error that we haven't been able to solve.
This introduces an ADR-like document to document the
findings thus far, and the de-facto decision to leave
the bug unresolved.

ARCHBOM-1150
@robrap robrap requested a review from a team August 17, 2021 21:52
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #212 (85dacf2) into master (aa1f399) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   81.56%   81.56%           
=======================================
  Files          38       38           
  Lines         868      868           
  Branches      152      152           
=======================================
  Hits          708      708           
  Misses        151      151           
  Partials        9        9           
Impacted Files Coverage Δ
src/auth/AxiosJwtTokenService.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa1f399...85dacf2. Read the comment docs.

@robrap robrap merged commit 75a2646 into master Aug 18, 2021
@robrap robrap deleted the robrap/ARCHBOM-1150-token-null-after-refresh branch August 18, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants