Conversation
DawoudSheraz
force-pushed
the
dsheraz/prod-343
branch
from
74e7f2e to
d201f7b
Compare
|
@bmedx Tagging you here for a quick code review as you were one of the suggestions for the reviewers. |
| # This file is autogenerated by pip-compile | ||
| # To update, run: | ||
| # | ||
| # pip-compile --output-file requirements/travis.txt requirements/travis.in |
There was a problem hiding this comment.
Can you add the following in the Makefile to avoid getting ^^ message in each .txt file?
upgrade: export CUSTOM_COMPILE_COMMAND=make upgrade
| include CONTRIBUTING.rst | ||
| include LICENSE.txt | ||
| include README.rst | ||
| include requirements/base.in |
There was a problem hiding this comment.
What is the role of adding / including the requirements file here?
There was a problem hiding this comment.
By including this file in the Manifest.in, the file will become available in the distribution package. It was needed as without it, the setup.py was not able to locate the requirements/base.in when defining install_requires through function.
bmedx
left a comment
bmedx
left a comment
There was a problem hiding this comment.
I was able to make upgrade and make requirements without issues. 👍
3 participants
Description: This PR updates the jinja2 to the latest version. Please see PROD-343 for more information.
JIRA: PROD-343
Dependencies: dependencies on other outstanding PRs, issues, etc.
Merge deadline: List merge deadline (if any)
Reviewers:
Merge checklist:
Post merge:
finished.
Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.