Skip to content

[ENT-8977] - feat: CRUD endpoints for SubscriptionPlan#642

Merged
hamzawaleed01 merged 22 commits into
masterfrom
ENT-8977/subscription-crud-endpoints
May 21, 2024
Merged

[ENT-8977] - feat: CRUD endpoints for SubscriptionPlan#642
hamzawaleed01 merged 22 commits into
masterfrom
ENT-8977/subscription-crud-endpoints

Conversation

@hamzawaleed01
Copy link
Copy Markdown
Contributor

@hamzawaleed01 hamzawaleed01 commented Apr 25, 2024 •
edited
Loading

Description

Description of changes made:

  • Added CRUD endpoints for SubscriptionPlan
  • Added serializers
  • Added tests
  • Some minor refactoring in admin forms to reuse provisioning methods in API views also

Link to the associated ticket: https://openedx.atlassian.net/browse/ENT-XXXX

Testing considerations

  • Include instructions for any required manual tests, and any manual testing that has
    already been performed.
  • Include unit and a11y tests as appropriate
  • Consider performance issues.
  • Check that Database migrations are backwards-compatible

Post-review

Squash commits into discrete sets of changes

@hamzawaleed01 hamzawaleed01 marked this pull request as draft April 25, 2024 09:51
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8977/subscription-crud-endpoints branch from 3101560 to 823e23b Compare April 25, 2024 11:21
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8977/subscription-crud-endpoints branch from 8175aa6 to c73ab76 Compare May 1, 2024 06:54
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8977/subscription-crud-endpoints branch from 0868363 to 55a4297 Compare May 2, 2024 15:36
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8977/subscription-crud-endpoints branch from 3c48281 to 9f5db0f Compare May 6, 2024 09:19
@hamzawaleed01
Merge branch 'ENT-8977/subscription-crud-endpoints' of github.com:ope…
095b1d1 
…nedx/license-manager into ENT-8977/subscription-crud-endpoints
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8977/subscription-crud-endpoints branch 4 times, most recently from 41cc926 to bd063bd Compare May 6, 2024 11:00
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8977/subscription-crud-endpoints branch from bd063bd to 3655614 Compare May 6, 2024 16:39
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8977/subscription-crud-endpoints branch 8 times, most recently from a69d3aa to e717176 Compare May 7, 2024 07:57
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8977/subscription-crud-endpoints branch from 5fc1f8e to f8b86ac Compare May 10, 2024 07:29
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8977/subscription-crud-endpoints branch 2 times, most recently from d013a70 to 89d9c26 Compare May 13, 2024 06:36
zamanafzal
zamanafzal reviewed May 13, 2024
View reviewed changes
Comment thread license_manager/apps/api/serializers.py Outdated
zamanafzal
zamanafzal reviewed May 13, 2024
View reviewed changes
Comment thread license_manager/apps/api/serializers.py Outdated
zamanafzal
zamanafzal reviewed May 13, 2024
View reviewed changes
Comment thread license_manager/apps/api/serializers.py Outdated
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8977/subscription-crud-endpoints branch 3 times, most recently from 1afa1c6 to 954227d Compare May 15, 2024 07:53
sameenfatima78
sameenfatima78 reviewed May 15, 2024
View reviewed changes
Comment thread license_manager/apps/subscriptions/utils.py Outdated
Comment thread license_manager/apps/api/v1/views.py
Comment thread license_manager/apps/subscriptions/exceptions.py
Comment thread license_manager/apps/subscriptions/tasks.py Outdated
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8977/subscription-crud-endpoints branch from 954227d to c23fbbd Compare May 16, 2024 05:32
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8977/subscription-crud-endpoints branch 2 times, most recently from bfde2ab to 88b4e3e Compare May 17, 2024 08:12
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8977/subscription-crud-endpoints branch from 88b4e3e to 876222f Compare May 17, 2024 08:14
sameenfatima78
sameenfatima78 reviewed May 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sameenfatima78 sameenfatima78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

submitted another round of feedback

Comment thread license_manager/apps/api/serializers.py Outdated
Comment thread license_manager/apps/api/serializers.py Outdated
Comment thread license_manager/apps/api/serializers.py Outdated
Comment thread license_manager/apps/api/serializers.py Outdated
Comment thread license_manager/apps/api/serializers.py Outdated
Comment thread license_manager/apps/api/v1/views.py Outdated
Comment thread license_manager/apps/api/v1/views.py Outdated
Comment thread license_manager/apps/subscriptions/models.py Outdated
Comment thread license_manager/apps/subscriptions/admin.py Outdated
Comment thread license_manager/apps/subscriptions/admin.py Outdated
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8977/subscription-crud-endpoints branch 3 times, most recently from 9e08bc1 to 8c35ea7 Compare May 20, 2024 07:51
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8977/subscription-crud-endpoints branch from 8c35ea7 to 963cb6a Compare May 20, 2024 07:54
sameenfatima78
sameenfatima78 approved these changes May 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sameenfatima78 sameenfatima78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Awesome work!

@hamzawaleed01 hamzawaleed01 merged commit 9024bf2 into master May 21, 2024
@hamzawaleed01 hamzawaleed01 deleted the ENT-8977/subscription-crud-endpoints branch May 21, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sameeramin sameeramin sameeramin left review comments

@zamanafzal zamanafzal zamanafzal approved these changes

@sameenfatima78 sameenfatima78 sameenfatima78 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hamzawaleed01 @zamanafzal @sameeramin @sameenfatima78