fix: propagate --upgrade flag to all pip-compile calls in make upgrade#254
fix: propagate --upgrade flag to all pip-compile calls in make upgrade#254
Conversation
The PIP_COMPILE macro did not include \${COMPILE_OPTS}, so only
pip.txt and pip-tools.txt were compiled with --upgrade. All other
files (base.txt, test.txt, quality.txt, etc.) were compiled without
it, keeping their existing pinned versions.
When a transitive dependency releases a new version, pip-tools.txt
would upgrade but the rest of the chain would not, causing version
conflicts in dev.txt (which includes both as -r inputs).
Aligns the Makefile with the pattern from openedx/openedx-core:
- Add --rebuild to the PIP_COMPILE macro
- Pass --upgrade via PIP_COMPILE_OPTS so all files get it uniformly
- Remove the split code path for pip.txt and pip-tools.txt
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
openedx-webhooks
added
open-source-contribution
|
Thanks for the pull request, @mariajgrimaldi! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
rodmgwgu
left a comment
rodmgwgu
left a comment
There was a problem hiding this comment.
Tested in my local, working fine, thanks!
bmtcril
left a comment
bmtcril
left a comment
There was a problem hiding this comment.
Hmm, I'm not clear on why it's needed but glad it works. Also glad that we're so close to being able to move to uv 😄
4 participants
Description
The PIP_COMPILE macro did not include ${COMPILE_OPTS}, so only pip.txt and pip-tools.txt were compiled with --upgrade. All other files (base.txt, test.txt, quality.txt, etc.) were compiled without it, keeping their existing pinned versions.
When a transitive dependency releases a new version, pip-tools.txt would upgrade but the rest of the chain would not, causing version conflicts in dev.txt (which includes both as -r inputs).
Aligns the Makefile with the pattern from openedx/openedx-core:
Merge checklist:
Check off if complete or not applicable: