Skip to content

feat: add advanced settings view permission for course roles#272

Draft
bra-i-am wants to merge 1 commit intoopenedx:mainfrom
eduNEXT:bc/add-advanced-settings-view-permission
Draft

feat: add advanced settings view permission for course roles#272
bra-i-am wants to merge 1 commit intoopenedx:mainfrom
eduNEXT:bc/add-advanced-settings-view-permission

Conversation

@bra-i-am
Copy link
Copy Markdown

@bra-i-am bra-i-am commented Apr 27, 2026

Description

Adds COURSES_VIEW_ADVANCED_SETTINGS permission to enable read-only access to advanced settings for the course_auditor role. Also adds COURSES_MANAGE_ADVANCED_SETTINGS to course_editor role for full access.
This change supports the read-only access feature for auditors in the Pages and Resources section of frontend-app-authoring MFE, allowing users with course_auditor role to view (but not modify) advanced settings.

Supporting information

Changes

  • permissions.py: Added COURSES_VIEW_ADVANCED_SETTINGS permission
  • roles.py: Added COURSES_VIEW_ADVANCED_SETTINGS to COURSE_AUDITOR_PERMISSIONS and COURSE_EDITOR_PERMISSIONS; added COURSES_MANAGE_ADVANCED_SETTINGS to COURSE_EDITOR_PERMISSIONS
  • authz.policy: Added policy rules for both permissions

How to test

  1. Assign course_auditor role to a user for a specific course
  2. The user should be able to access the Advanced Settings page in Studio but all form fields should be disabled (read-only mode)
  3. Assign course_editor role to a user
  4. The user should have full access (read + write) to Advanced Settings

Merge checklist

Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 27, 2026
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @bra-i-am!

This repository is currently maintained by @openedx/committers-openedx-authz.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

3 participants