Minor fixes for tagging django admin [FC-0036] #114
Conversation
|
Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
3ba1a6c to
20071df
Compare
pomegranited
left a comment
There was a problem hiding this comment.
👍 Thank you for these fixes @bradenmacdonald !
- I tested this using Django Admin on my devstack.
- I read through the code
-
I checked for accessibility issuesN/A - Includes documentation
|
|
||
| lookup_value_regex = r"\d+" | ||
| # System taxonomies use negative numbers for their primary keys | ||
| lookup_value_regex = r'-?\d+' |
There was a problem hiding this comment.
Thanks for this fix - looks good! 👍🏻
|
@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This fixes a few minor issues I found while reviewing openedx/openedx-platform#33563 :
_taxonomy_classdidn't haveblank=True. I fixed that.ObjectTag.tagwere loading all possible tags into a select widget, which could be hundreds of thousands. I changed it to an auto-complete widget._taxonomy_classset. I think this is due to the messy migration history. I included a fix in case anyone else has the same issue on their machine. I was trying to figure out why the API was not showing "Languages" as system-defined.ObjectTag before:
ObjectTag after:
Tag before:
Tag after:
Private-ref: FAL-3523