Very minor fixes for import code [FC-0036]#122
Merged
bradenmacdonald merged 1 commit intomainfrom Nov 21, 2023
Merged
Conversation
|
Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
ormsbee
approved these changes
Nov 21, 2023
pomegranited
approved these changes
Nov 21, 2023
Contributor
pomegranited
left a comment
There was a problem hiding this comment.
👍
- I tested this by running this branch in my devstack and testing importing a taxonomy CSVs and JSONs
- I read through the code
-
I checked for accessibility issuesN/A -
Includes documentationN/A -
User-facing strings are extracted for translationN/A
|
@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BinaryIO(any file-like object that produces bytes), notBytesIO(specifically an in-memory bytes object and not a file handle)TypeErroroccurred during import (e.g. because you forgot to open the CSV file as binary instead of as a string...) then the import task would become permanently stuck becauseTypeErrorexceptions were not caught.No need for a version bump with this fix.
Private ref: can be considered part of FAL-3531.