fix: skip parent update from deleted tags #126
Merged
bradenmacdonald merged 1 commit intoopenedx:mainfrom Dec 4, 2023
Merged
Conversation
|
Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
956958d to
140fb6c
Compare
140fb6c to
dace8b8
Compare
2ad5ec4 to
537c6a0
Compare
537c6a0 to
5eef869
Compare
pomegranited
added a commit
to open-craft/openedx-platform
that referenced
this pull request
Dec 4, 2023
Use WIP branch from openedx/openedx-core#126
bradenmacdonald
approved these changes
Dec 4, 2023
Contributor
|
Merging now. I see there's no version bump - let me know if we need to add one at some point, or just wait to combine this with other changes. |
|
@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR prevents creating an
UpdateParentaction associated with a Tag that will be deleted.Example:
Actions before PR:
Actions after PR:
It also checks if the Tag actually exists in the database before executing the
Deleteaction. In the example above, because we didn't update the parent of tags 1.1 and 1.1.1, actions#2and#3should be skipped because both tags were cascade deleted on action#1.Testing instructions
Private-ref: