Skip to content

[FC-0049] feat: Auto generate taxonomy export ID if not provided#182

Merged
bradenmacdonald merged 1 commit intoopenedx:mainfrom
open-craft:yusuf-musleh/generate-taxonomy-export-id-if-not-provided
Apr 18, 2024
Merged

[FC-0049] feat: Auto generate taxonomy export ID if not provided#182
bradenmacdonald merged 1 commit intoopenedx:mainfrom
open-craft:yusuf-musleh/generate-taxonomy-export-id-if-not-provided

Conversation

@yusuf-musleh
Copy link
Member

@yusuf-musleh yusuf-musleh commented Apr 18, 2024

Description

This changes the import taxonomy view to allow users to import a taxonomy without specifying an export id. If it is provided it will use it otherwise, it will generate one.

Supporting information

Related Tickets:

Testing instructions

  1. Follow the testing instructions in [FC-0049] feat: Remove taxonomy export id prompt frontend-app-authoring#955
  2. Confirm the tests cover this condition

Private-ref: FAL-3706

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 18, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 18, 2024

Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/generate-taxonomy-export-id-if-not-provided branch 2 times, most recently from d5039e9 to 48d4ad9 Compare April 18, 2024 14:05
@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/generate-taxonomy-export-id-if-not-provided branch from 48d4ad9 to b64e8ee Compare April 18, 2024 14:43
@yusuf-musleh yusuf-musleh changed the title feat: Auto generate taxonomy export ID if not provided [FC-0049] feat: Auto generate taxonomy export ID if not provided Apr 18, 2024
@yusuf-musleh yusuf-musleh marked this pull request as ready for review April 18, 2024 14:52
Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yusuf-musleh Looks good! 👍

  • I tested this: I followed the testing instructions of openedx/frontend-app-authoring#955
  • I read through the code and considered the security, stability and performance implications of the changes.
  • Includes tests for bugfixes and/or features added.
  • Includes documentation

@bradenmacdonald bradenmacdonald merged commit 4305c29 into openedx:main Apr 18, 2024
@openedx-webhooks
Copy link

@yusuf-musleh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@bradenmacdonald bradenmacdonald deleted the yusuf-musleh/generate-taxonomy-export-id-if-not-provided branch April 18, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants