fix: prevent soft-deletes from being re-published every time#211
Merged
ormsbee merged 1 commit intoopenedx:mainfrom Aug 16, 2024
Merged
fix: prevent soft-deletes from being re-published every time#211ormsbee merged 1 commit intoopenedx:mainfrom
ormsbee merged 1 commit intoopenedx:mainfrom
Conversation
624acce to
6699388
Compare
31677f3 to
b3dd189
Compare
Contributor
Author
|
@pomegranited or @navinkarkera: Review if one of you has time, please? |
navinkarkera
approved these changes
Aug 16, 2024
Contributor
navinkarkera
left a comment
There was a problem hiding this comment.
@ormsbee Looks good. 👍
- I tested this: Published library with soft deleted components and verified that they are not included in the publish log records.
- I read through the code
- Includes documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details are in a comment from this change: