Simplify tagging queries with a view that uses recursive CTEs#510
Simplify tagging queries with a view that uses recursive CTEs#510bradenmacdonald wants to merge 14 commits intomainfrom
Conversation
|
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
This is a proposed fix for openedx/modular-learning#257 .
Approach: It uses recursive common table expressions to update the API to support taxonomies of unlimited depth. This is mostly an implementation detail, and the API does not change except for returning more results in the case where it was previously limited to a depth of 3.
Actual depth limit: This PR also clarifies the definition of
TAXONOMY_MAX_DEPTHand actually enforces it to limit the allowed depth to six levels. (Before this, no limit was enforced when creating tags! A limit of 3 levels was enforced when reading tags from multiple levels at once, but it didn't work well below the root.)Perfomance: This implementation is ever so slightly slower, but it's not significant. Compare it's test run (4m43s) with a recent master test run (4m34s). If we need to improve performance in the future, a path to doing so is outlined in the
TagComputeddocstring, although it would require a more significant refactor of the implementation.AI disclosure: Claude wrote the CTE queries and helped with some of the refactoring.