feat: typed PK identifiers for Units/Subsections/Sections#535
feat: typed PK identifiers for Units/Subsections/Sections#535bradenmacdonald merged 1 commit intobraden/typed-pksfrom
Conversation
|
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Looks good to me 👍🏻 (If we end up finding the casting too cumbersome, then I think that's an indication that the container subclass models shouldn't exist.) |
7c4354a to
37f9721
Compare
This is an optional extension to #534 which further breaks
Container.PKdown intoUnit.PK,Subsection.PK,Section.PKkey types.For now it works smoothly and has a very small diff to implement. But I am worried that it could add more complexity (and require more casting) than it's worth down the road? Hard to say. Since we don't have much difference between the container types at the moment, I'm not sure what the trade-offs are here.