revert: emit events so that deleting tag(s) updates studio search index#577
Closed
kdmccormick wants to merge 1 commit intomainfrom
Closed
revert: emit events so that deleting tag(s) updates studio search index#577kdmccormick wants to merge 1 commit intomainfrom
kdmccormick wants to merge 1 commit intomainfrom
Conversation
When a tag is deleted by CASCADE of another model (for example, deleting a Taxonomy), it causes a TypeError in _is_explicit_tag_delete, which expects the event origin to always be a Tag or QuerySet[Tag]. Bumps to 1.0.1 This reverts commit 508be7d.
This was referenced Apr 30, 2026
Member
Author
|
Closed in favor of #575 |
kdmccormick
deleted the
kdmccormick/revert-tag-delete-updates-meilisearch
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge info
For Verawood, we need to merge either this PR, or the fix-forward PR: #575. Both are ready to go.
Description
When a tag is deleted by CASCADE of another model (for example, deleting a Taxonomy), it causes a TypeError in _is_explicit_tag_delete, which expects the event origin to always be a Tag or QuerySet[Tag].
Bumps to 1.0.1
This reverts commit 508be7d.
Supporting
See #575 for more details and a proposed fix.
AI
I used Claude Sonnet 4.6 in #575 to confirm that there was indeed a bug, but I did the revert by hand.