pii_check may not really be checking

[robrap]

Here is the code for pii_check:

• openedx-platform/Makefile

  Lines 177 to 191 in 7c68f1d

  	## Re-enable --lint flag when this issue https://github.com/openedx/edx-platform/issues/35775 is resolved
  	pii_check: ## check django models for pii annotations
  	DJANGO_SETTINGS_MODULE=cms.envs.test \
  	code_annotations django_find_annotations \
  	--config_file .pii_annotations.yml \
  	--app_name cms \
  	--coverage \
  	--lint
  	DJANGO_SETTINGS_MODULE=lms.envs.test \
  	code_annotations django_find_annotations \
  	--config_file .pii_annotations.yml \
  	--app_name lms \
  	--coverage \
  	--lint

  • This uses --app_name cms, which doesn't seem to be matching anything.
  • Also, line 177 has comment about "Re-enable --lint flag", which seems to already be done?

Possibly the target might be missed, given we don't seem to really have been checking?

• openedx-platform/.pii_annotations.yml

  Line 4 in 7c68f1d

  coverage_target: 85.3

Relevant recent issues and docs:

• Re-enable pii_check linting #35775
• https://docs.openedx.org/projects/edx-platform/en/latest/decisions/0021-fixing-quality-and-js-checks.html#pii-check

In addition to fixing, maybe we could implement or ticket ensuring this doesn't regress again? It seems this isn't the first time this broke and no one noticed.

[kdmccormick]

For some context, we noticed the pii_check wasn't doing anything back in 2024 during the Paver DEPR, so we lowered its threshhold (down to the current 85.3%) in order to re-enable it: #35775

Seems that either we failed to really re-enable it, or something externally changed since then that has made it a no-op.