fix: "Invalid type for parameter ContentType" error on js upload#25957
fix: "Invalid type for parameter ContentType" error on js upload#25957jmbowman merged 1 commit intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @regisb! I've created OSPR-5319 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
@regisb Thank you for your contribution. Looks like this is ready for our review, correct? |
|
Thanks @natabene! Yes, this is ready for review. |
jmbowman
left a comment
There was a problem hiding this comment.
Sorry for the delay in reviewing; looks fine to me once it's rebased. We'll be going through shortly and dropping the rest of the constraints that were only there for Python 3.5 support, just hadn't gotten to it yet.
We are affected by this issue: jazzband/django-pipeline#297 (comment) In particular, this occurs when trying to upload js assets to s3, such as with the Scorm xblock: overhangio/openedx-scorm-xblock#16 This issue is resolved by upgrading django-pipeline to 2.0.3+, as the fix was introduced here: jazzband/django-pipeline#715
|
rebased! |
a4e732a to
c656ce0
Compare
|
Your PR has finished running tests. There were no failures. |
|
@regisb 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
Thanks @jmbowman :) |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
…pload This fix is useless and should be reverted once https://github.com/edx/edx-platform/pull/25957 is merged into the Tahoe branch when Maple is used.
…nedx#25957) We are affected by this issue: jazzband/django-pipeline#297 (comment) In particular, this occurs when trying to upload js assets to s3, such as with the Scorm xblock: overhangio/openedx-scorm-xblock#16 This issue is resolved by upgrading django-pipeline to 2.0.3+, as the fix was introduced here: jazzband/django-pipeline#715 (cherry picked from commit d89868b)
We are affected by this issue:
jazzband/django-pipeline#297 (comment)
In particular, this occurs when trying to upload js assets to s3, such
as with the Scorm xblock:
overhangio/openedx-scorm-xblock#16
This issue is resolved by upgrading django-pipeline to 2.0.3+, as the
fix was introduced here:
jazzband/django-pipeline#715