Skip to content

Comments

fix: float " " symbol in the preview_body#32489

Merged
AhtishamShahid merged 2 commits intoopenedx:open-release/palm.masterfrom
DmytroAlipov:fix-discussion-preview-body-palm
Sep 5, 2023
Merged

fix: float " " symbol in the preview_body#32489
AhtishamShahid merged 2 commits intoopenedx:open-release/palm.masterfrom
DmytroAlipov:fix-discussion-preview-body-palm

Conversation

@DmytroAlipov
Copy link
Contributor

Description

The issue is with the preview_body field when formatting the post body. If there are multiple consecutive spaces in the body of a post, the space character is replaced with  .

Before:

screen_2

After:

<img width="1026" alt="screen_1" src="https://github.com/openedx/edx-platform/assets/98233552/33bca474-83f7-4685-b5ef-55324b73fe97"

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 16, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Jun 16, 2023

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@DmytroAlipov DmytroAlipov force-pushed the fix-discussion-preview-body-palm branch 2 times, most recently from 2d1b564 to 6998e64 Compare June 23, 2023 08:00
@mphilbrick211 mphilbrick211 requested a review from asadazam93 June 28, 2023 18:39
@mphilbrick211
Copy link

Hi @asadazam93! Would you, or someone from @openedx/edx-infinity, be able to review/merge this for us? Thanks!

@asadazam93 asadazam93 requested a review from awais-ansari July 4, 2023 07:11
@asadazam93
Copy link
Contributor

@DmytroAlipov is there another PR to merge this fix in master?

@DmytroAlipov
Copy link
Contributor Author

@asadazam93 yes, of course. here

@mphilbrick211
Copy link

Hi @openedx/edx-infinity! Is someone able to merge this for us? Thanks!

@mphilbrick211
Copy link

Hi @openedx/edx-infinity! Is someone able to merge this for us? Thanks!

Hi @openedx/edx-infinity! just following up on this :)

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Sep 1, 2023

@mphilbrick211: I'm adding this PR to the BTR list of backports. I can merge it :)

@mphilbrick211
Copy link

@mphilbrick211: I'm adding this PR to the BTR list of backports. I can merge it :)

Thanks so much, @mariajgrimaldi!

@AhtishamShahid AhtishamShahid merged commit 1699d14 into openedx:open-release/palm.master Sep 5, 2023
@openedx-webhooks
Copy link

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@DmytroAlipov DmytroAlipov deleted the fix-discussion-preview-body-palm branch September 5, 2023 13:54
shURenZHOUluxun pushed a commit to EduTrigger/edx-platform that referenced this pull request Jan 3, 2024
Co-authored-by: Edward Zarecor <ezarecor@tcril.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

8 participants