feat!: upgrading django-storages to 1.10.1#32571
Merged
Conversation
awais786
force-pushed
the
django-storages-upgrade
branch
from
6bf30af to
275c37d
Compare
Contributor
Author
|
https://github.com/jschneier/django-storages/pull/520/files |
awais786
force-pushed
the
django-storages-upgrade
branch
from
ac4330e to
3845490
Compare
awais786
commented
Aug 18, 2023
| base_url=MEDIA_URL, | ||
| ), | ||
| DIRECTORY_PREFIX='video-images/', | ||
| BASE_URL=MEDIA_URL, |
Contributor
Author
There was a problem hiding this comment.
These values override for sandbox and stage/prod and there base_url does not exists. Its for devstack.
iamsobanjaved
approved these changes
Aug 21, 2023
awais786
commented
Aug 25, 2023
| 'STORAGE_CLASS': 'storages.backends.s3boto3.S3Boto3Storage', | ||
| 'STORAGE_KWARGS': | ||
| {'bucket_name': 'test', 'default_acl': None, 'base_url': '/', 'location': 'abc/def'}} | ||
| {'bucket_name': 'test', 'default_acl': None, 'location': 'abc/def'}} |
Contributor
Author
There was a problem hiding this comment.
Constructor now verifies its passing params and base_url is unknown for this package.
DawoudSheraz
approved these changes
Aug 25, 2023
Contributor
DawoudSheraz
left a comment
DawoudSheraz
left a comment
There was a problem hiding this comment.
CI is green 👍🏽 . Although, once the changes land on the stage, verify the upload is working as expected.
awais786
added a commit
that referenced
this pull request
Aug 28, 2023
awais786
added a commit
that referenced
this pull request
Aug 28, 2023
awais786
added a commit
that referenced
this pull request
Aug 28, 2023
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
awais786
added a commit
that referenced
this pull request
Aug 28, 2023
awais786
added a commit
that referenced
this pull request
Aug 30, 2023
awais786
added a commit
that referenced
this pull request
Aug 30, 2023
Yagnesh1998
pushed a commit
to ManpraXSoftware/edx-platform
that referenced
this pull request
Sep 1, 2023
* feat!: upgrading django-storages to 1.10.1
Yagnesh1998
pushed a commit
to ManpraXSoftware/edx-platform
that referenced
this pull request
Sep 1, 2023
…penedx#33109) This reverts commit 9281ea4.
Yagnesh1998
pushed a commit
to ManpraXSoftware/edx-platform
that referenced
this pull request
Sep 1, 2023
…2571)" (openedx#33109)" (openedx#33111) This reverts commit 191b825.
Yagnesh1998
pushed a commit
to ManpraXSoftware/edx-platform
that referenced
this pull request
Sep 1, 2023
…penedx#32571)" (openedx#33109)" (openedx#33111)" (openedx#33113) This reverts commit 2f8475c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version has several breaking changes few of them are
For complete change log please review this.
https://github.com/jschneier/django-storages/blob/master/CHANGELOG.rst#1101-2020-09-13
buckettobucket_namechanges in in all places. ( platform and config )acland others key changes SRE needs to review the config files.NOTE: