feat: Create content in library permission added to API response#34934
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
ChrisChV
force-pushed
the
chris/FAL-3754-permission-in-library
branch
from
4acbffa to
a1ee71f
Compare
mphilbrick211
added
the
needs reviewer assigned
ChrisChV
force-pushed
the
chris/FAL-3754-permission-in-library
branch
from
a5c44cc to
5f0ecef
Compare
There was a problem hiding this comment.
LGTM 👍 @ChrisChV ! Good work.
I added a nit, but not blocking.
- I tested this: I followed the testing from the course-authoring PR
- I read through the code and considered the security, stability and performance implications of the changes.
- Includes tests for bugfixes and/or features added.
|
@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
| slug = serializers.CharField(source="key.slug", validators=(validate_unicode_slug, )) | ||
| bundle_uuid = serializers.UUIDField(format='hex_verbose', read_only=True) | ||
| collection_uuid = serializers.UUIDField(format='hex_verbose', write_only=True) | ||
| #collection_uuid = serializers.UUIDField(format='hex_verbose', write_only=True) |
There was a problem hiding this comment.
@ChrisChV @bradenmacdonald: Did you mean to leave a commented out line of code? Shouldn't it just be deleted?
I only happened to look at this PR because the tests failed on master (at first) due to some issue uploading an artifact, but it passed after I re-ran (or maybe after Braden had)?
There was a problem hiding this comment.
Sorry, just an oversight on my part. I should have asked for that line to be deleted during the review. We're doing lots of work in this area though, so we'll remove it in a follow-up pass.
|
2U Release Notice: This PR has been deployed to the edX production environment. |
itsjeyd
removed
the
needs reviewer assigned
8 participants
Description
This PR includes this changes:
Supporting information
Newbutton.Testing instructions