feat: added group_by_id field in notifications model#35137
Merged
muhammadadeeltajamul merged 4 commits intomasterfrom Jul 23, 2024
Merged
feat: added group_by_id field in notifications model#35137muhammadadeeltajamul merged 4 commits intomasterfrom
muhammadadeeltajamul merged 4 commits intomasterfrom
Conversation
| email = models.BooleanField(default=False, null=False, blank=False) | ||
| last_read = models.DateTimeField(null=True, blank=True) | ||
| last_seen = models.DateTimeField(null=True, blank=True) | ||
| group_by_id = models.CharField(max_length=255, null=True, default="") |
Contributor
There was a problem hiding this comment.
I think that charfield 225 is too much for id, and max_length 20 would be sufficient.
Contributor
There was a problem hiding this comment.
32 characters I think to be safe
Contributor
There was a problem hiding this comment.
We will be running queries on this field so might be a good idea to index it
Contributor
Author
There was a problem hiding this comment.
I am planning to set it to 36 characters (equal to length of UUID)
AhtishamShahid
approved these changes
Jul 19, 2024
muhammadadeeltajamul
force-pushed
the
inf-1471
branch
from
d61700f to
71499f6
Compare
asadazam93
approved these changes
Jul 23, 2024
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
mudassir-hafeez
pushed a commit
to mudassir-hafeez/edx-platform
that referenced
this pull request
Jul 24, 2024
mudassir-hafeez
pushed a commit
to mudassir-hafeez/edx-platform
that referenced
this pull request
Jul 24, 2024
mudassir-hafeez
pushed a commit
to mudassir-hafeez/edx-platform
that referenced
this pull request
Jul 24, 2024
mudassir-hafeez
pushed a commit
to mudassir-hafeez/edx-platform
that referenced
this pull request
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
group_by_idfield in notification modelTicket Link: INF-1471