-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix: Call json_safe on globals in codejail remote_exec #36542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We need to make globals JSON-friendly before sending them across the network. Addresses edx/edx-arch-experiments#1016
|
@MoisesGSalas Tagging you since this might be relevant to your deployment. I'd be curious if you've seen any of these errors. Here's a sample of what they look like (though the error message itself will differ if you're calling remote directly instead of calling it via darklaunch): We've seen very few of these, so they may be specific to some custom XBlock. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
We need to make globals JSON-friendly before sending them across the network. Addresses edx/edx-arch-experiments#1016
|
Hi @timmc-edx, sorry for the late response. I did a quick check on the instances that use codejail the most but none had any serialization errors. |
|
Thanks for the update! |
We need to make globals JSON-friendly before sending them across the network. Addresses edx/edx-arch-experiments#1016
We need to make globals JSON-friendly before sending them across the network. Addresses edx/edx-arch-experiments#1016
We need to make globals JSON-friendly before sending them across the network.
Addresses edx/edx-arch-experiments#1016