fix: Use correct default for unsafely param#36638
Merged
Conversation
`unsafely` should be a boolean, not None. I believe this is what was causing a 400 in remote codejail-service calls (during darklaunch) when the `calculate_problem_responses_csv.v2` instructor task ran: edx/edx-arch-experiments#1028 There are also places in the code where this member appears to be a scalar property instead of a method, or possibly that's just buggy code that doesn't run. I decided not to touch that in this PR (we're probably going to DEPR the entire unsafe mechanism anyhow) but if this PR doesn't work, that's the next place to look -- because higher up in this file there's a `can_execute_unsafe_code=None` that we could try changing.
robrap
approved these changes
Apr 30, 2025
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
UsamaSadiq
pushed a commit
that referenced
this pull request
May 14, 2025
`unsafely` should be a boolean, not None. I believe this is what was causing a 400 in remote codejail-service calls (during darklaunch) when the `calculate_problem_responses_csv.v2` instructor task ran: edx/edx-arch-experiments#1028 There are also places in the code where this member appears to be a scalar property instead of a method, or possibly that's just buggy code that doesn't run. I decided not to touch that in this PR (we're probably going to DEPR the entire unsafe mechanism anyhow) but if this PR doesn't work, that's the next place to look -- because higher up in this file there's a `can_execute_unsafe_code=None` that we could try changing.
timmc-edx
added a commit
that referenced
this pull request
May 14, 2025
`unsafely` should be a boolean, not None. I believe this is what was causing a 400 in remote codejail-service calls (during darklaunch) when the `calculate_problem_responses_csv.v2` instructor task ran: edx/edx-arch-experiments#1028 There are also places in the code where this member appears to be a scalar property instead of a method, or possibly that's just buggy code that doesn't run. I decided not to touch that in this PR (we're probably going to DEPR the entire unsafe mechanism anyhow) but if this PR doesn't work, that's the next place to look -- because higher up in this file there's a `can_execute_unsafe_code=None` that we could try changing. (cherry picked from commit c9ae3ad)
marlonkeating
pushed a commit
that referenced
this pull request
Jul 15, 2025
`unsafely` should be a boolean, not None. I believe this is what was causing a 400 in remote codejail-service calls (during darklaunch) when the `calculate_problem_responses_csv.v2` instructor task ran: edx/edx-arch-experiments#1028 There are also places in the code where this member appears to be a scalar property instead of a method, or possibly that's just buggy code that doesn't run. I decided not to touch that in this PR (we're probably going to DEPR the entire unsafe mechanism anyhow) but if this PR doesn't work, that's the next place to look -- because higher up in this file there's a `can_execute_unsafe_code=None` that we could try changing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unsafelyshould be a boolean, not None. I believe this is what was causing a 400 in remote codejail-service calls (during darklaunch) when thecalculate_problem_responses_csv.v2instructor task ran: edx/edx-arch-experiments#1028There are also places in the code where this member appears to be a scalar property instead of a method, or possibly that's just buggy code that doesn't run. I decided not to touch that in this PR (we're probably going to DEPR the entire unsafe mechanism anyhow) but if this PR doesn't work, that's the next place to look -- because higher up in this file there's a
can_execute_unsafe_code=Nonethat we could try changing.