-
Notifications
You must be signed in to change notification settings - Fork 4.2k
chore: remove version constraint on django-simple-history #36814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove version constraint on django-simple-history #36814
Conversation
|
Thanks for the pull request, @wgu-taylor-payne! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
f551bc6 to
b6314f8
Compare
…to 3.8.0 Remove pin on 3.4.0 to allow newer versions of the package.
b6314f8 to
4f58823
Compare
| # Date: 2024-02-02 | ||
| # incremental upgrade | ||
| django-simple-history==3.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable. The comment isn't really clear about why it was added. @iamsobanjaved - can you shed any light? Can we move forward with this without causing issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was added when we were a few versions behind on django-simple-history, and we plan to upgrade incrementally, version by version.
feanil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to put this on the regular upgrade path. If we run into major version changes, we should review them along with any other regular requirements upgrades. Pinning it here just makes it more likely that we'll fall behind.
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
Remove pin on django-simple-history version 3.4.0 in constraints file to allow newer versions of the package. This allows for compatibility with newer versions of Django.
There are no breaking changes introduced in versions 3.5.0 through 3.8.0 (see releases). Version 3.8.0 supports Django 4.2 through 5.2 and Python 3.9 through 3.13.
Supporting information
Resolves #36747. This PR is a part of the effort to add Django 5.2 support.
The pin for django-simple-history to 3.4.0 was introduced in this PR. I didn't find any further explanation for the pin.