Skip to content

fix: create preferences for all types instead of core#36984

Merged
muhammadadeeltajamul merged 1 commit intomasterfrom
inf-1963-2
Jul 4, 2025
Merged

fix: create preferences for all types instead of core#36984
muhammadadeeltajamul merged 1 commit intomasterfrom
inf-1963-2

Conversation

@muhammadadeeltajamul
Copy link
Copy Markdown
Contributor

Create preferences for all notification types instead of core

Creates missing account level preferences for notifications
"""
preferences = list(preferences)
notification_types = list(set(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much simpler way to find and create missing preferences . may be we we can extract this code in another function if needed.
https://github.com/openedx/edx-platform/pull/36957/files#diff-ff9c6979d67deaf0053d33346b0f3eb30ab3ec9ae530227826ce685fa2a9e635R659

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have complicated imports in notifications app. It will create circular import problem

@muhammadadeeltajamul muhammadadeeltajamul merged commit c812297 into master Jul 4, 2025
49 checks passed
@muhammadadeeltajamul muhammadadeeltajamul deleted the inf-1963-2 branch July 4, 2025 09:45
@edx-pipeline-bot
Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants