Skip to content

Conversation

@rayzhou-bit
Copy link
Contributor

@rayzhou-bit rayzhou-bit commented Oct 10, 2025

Description

This PR future proofs artifact uploads to prevent the following error by creating unique artifact names.

Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

This error used to occur when we had 2 django-version shards. It can potentially occur again if another shard is added for python, django, mongo or os version. This is due to github jobs running in parallel and attempting to upload artifacts with the same name at the same time.

Historically, this error triggered a lot when processing lms-4 (dj=pinned) and lms-4 (dj=5.2) since this shard took a longer time. For other shards, the artifact upload would finish on one job and the next job would delete before uploading another artifact with the same name. We were also losing logs on our unit tests because we were deleting them. This PR incidentally future proofs this as well.

Supporting information

#36160

Testing instructions

  1. In Github action's unit-test summary page, scroll down to the artifacts section at the bottom.
  2. Download pytest-warnings-json and open it.
  3. The folder should contain files with names that contain the python, django, mongo and os version. With our current config, you should see a pytest_warnings_xmodule-with-lms for ubuntu 22.04 and ubuntu 24.04.

Deadline

None

Copy link
Contributor

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Maybe we'll want to close the issue and note why? We can always re-open if it returns.

@rayzhou-bit rayzhou-bit merged commit da2daf2 into master Oct 14, 2025
53 checks passed
@rayzhou-bit rayzhou-bit deleted the fix--unit-test-CreateArtifact-error branch October 14, 2025 22:32
@rayzhou-bit rayzhou-bit restored the fix--unit-test-CreateArtifact-error branch October 17, 2025 15:53
rayzhou-bit added a commit to edx/edx-platform that referenced this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants