feat: future proof artifact uploads #37464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR future proofs artifact uploads to prevent the following error by creating unique artifact names.
This error used to occur when we had 2 django-version shards. It can potentially occur again if another shard is added for python, django, mongo or os version. This is due to github jobs running in parallel and attempting to upload artifacts with the same name at the same time.
Historically, this error triggered a lot when processing lms-4 (dj=pinned) and lms-4 (dj=5.2) since this shard took a longer time. For other shards, the artifact upload would finish on one job and the next job would delete before uploading another artifact with the same name. We were also losing logs on our unit tests because we were deleting them. This PR incidentally future proofs this as well.
Supporting information
#36160
Testing instructions
unit-testsummary page, scroll down to the artifacts section at the bottom.pytest-warnings-jsonand open it.Deadline
None