refactor: a ContentLibrary must have a LearningPackage#37499
Open
ormsbee wants to merge 6 commits intoopenedx:masterfrom
Open
refactor: a ContentLibrary must have a LearningPackage#37499ormsbee wants to merge 6 commits intoopenedx:masterfrom
ormsbee wants to merge 6 commits intoopenedx:masterfrom
Conversation
The learning_package of a ContentLibrary was originally made to be an optional, nullable field for backwards compatibility. We were re-using the same table when we transitioned from making v2 libraries be Blockstore-based to making them Learning Core-based. Since that time, Blockstore has been removed completely, and those prototype v2 libraries are not functional anyway. This commit removes those non-functional libraries and requires that all new libraries going forward have a LearningPackage. Note that this does not affect v1 legacy libraries that are backed by Modulestore.
Contributor
Author
|
Tested this locally on my machine: |
…the ContentLibrary model
Contributor
Author
|
Hah, now it's running into LTI-launch tests that we never ripped out. 😞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The learning_package of a ContentLibrary was originally made to be an
optional, nullable field for backwards compatibility. We were re-using
the same table when we transitioned from making v2 libraries be
Blockstore-based to making them Learning Core-based. Since that time,
Blockstore has been removed completely, and those prototype v2 libraries
are not functional anyway.
This commit removes those non-functional libraries and requires that all
new libraries going forward have a LearningPackage.
Note that this does not affect v1 legacy libraries that are backed by
Modulestore.
Implements #37443