feat: allows a reversion of the retirement partner report reset toggle #37539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to be overly enthusiastic about how many retirement partner reports are reset at once, in such a way that the system struggles to handle how many have been reset. This allows you to revert that change. FIXES: APER-4177
jsnwesson
reviewed
Oct 24, 2025
Comment on lines
194
to
197
| message_bit = "one user was" | ||
| else: | ||
| message_bit = "%s users were" % rows_updated | ||
| self.message_user(request, "%s successfully reset." % message_bit) |
Member
There was a problem hiding this comment.
Just to clarify, should the message be the same for both reset_state_false and reset_state_true?
MaxFrank13
approved these changes
Oct 24, 2025
textual feedback improvement suggestion from code review
…-report-reset_toggle
jsnwesson
approved these changes
Oct 24, 2025
deborahgu
deleted the
dkaplan1/APER-4177_prod-retirement-partner-report-reset_toggle
branch
deborahgu
added a commit
to edx/edx-platform
that referenced
this pull request
Oct 24, 2025
openedx#37539) * feat: allows a reversion of the retirement partner report reset toggle This allows you to set retirement partner report statuses to True as well as to False. One sample use case: if an overly large number of retirement partner reports have their status reset to false, the partner report queue can struggle to deal with the large queue. FIXES: APER-4177
haftamuk
pushed a commit
to haftamuk/edx-platform
that referenced
this pull request
Nov 3, 2025
openedx#37539) * feat: allows a reversion of the retirement partner report reset toggle This allows you to set retirement partner report statuses to True as well as to False. One sample use case: if an overly large number of retirement partner reports have their status reset to false, the partner report queue can struggle to deal with the large queue. FIXES: APER-4177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to be overly enthusiastic about how many retirement partner reports are reset at once, in such a way that the system struggles to handle how many have been reset. This allows you to revert that change.
FIXES: APER-4177
Description
Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.
Useful information to include:
"Developer", and "Operator".
changes.
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.