Skip to content

Move waffle flags, configs to video service #37631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
farhan merged 1 commit into from
Nov 17, 2025
Merged

Move waffle flags, configs to video service #37631

farhan merged 1 commit into from
Nov 17, 2025
+79 −20

Conversation

@farhan
Copy link
Contributor

@farhan farhan commented Nov 13, 2025 •
edited
Loading

Ticket: #36282

@farhan farhan force-pushed the farhan/add-waffle-flags branch from 7d1eeab to 7418e07 Compare November 14, 2025 07:05
@farhan farhan marked this pull request as ready for review November 14, 2025 08:02
@farhan farhan added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Nov 14, 2025
@open-craft-grove
Copy link

open-craft-grove commented Nov 14, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@kdmccormick kdmccormick self-requested a review November 14, 2025 16:21
@open-craft-grove
Copy link

open-craft-grove commented Nov 14, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

kdmccormick
kdmccormick approved these changes Nov 14, 2025
View reviewed changes
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small requests, but merge away once those are resolved 👍🏻

@open-craft-grove
Copy link

open-craft-grove commented Nov 15, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Nov 15, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@farhan farhan force-pushed the farhan/add-waffle-flags branch from 7418e07 to 4df35f9 Compare November 17, 2025 09:30
@open-craft-grove
Copy link

open-craft-grove commented Nov 17, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@farhan farhan merged commit a50ab7d into master Nov 17, 2025
53 checks passed
@farhan farhan deleted the farhan/add-waffle-flags branch November 17, 2025 12:52
@farhan farhan mentioned this pull request Jan 23, 2026
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kdmccormick kdmccormick kdmccormick approved these changes

@irtazaakram irtazaakram Awaiting requested review from irtazaakram irtazaakram is a code owner

@salman2013 salman2013 Awaiting requested review from salman2013 salman2013 is a code owner

Assignees

No one assigned

Labels

create-sandbox open-craft-grove should create a sandbox environment from this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@farhan @open-craft-grove @kdmccormick