fix: bump learning-core to 0.30.2#37729
Conversation
|
Thanks for the pull request, @dwong2708! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
71af1c0 to
484b0c0
Compare
requirements/common_constraints.txt
Outdated
|
|
||
| # pip 25.3 is incompatible with pip-tools hence causing failures during the build process | ||
| # Make upgrade command and all requirements upgrade jobs are broken due to this. | ||
| # See issue https://github.com/openedx/public-engineering/issues/440 for details regarding the ongoing fix. | ||
| # The constraint can be removed once a release (pip-tools > 7.5.1) is available with support for pip 25.3 | ||
| # Issue to track this dependency and unpin later on: https://github.com/openedx/edx-lint/issues/503 | ||
|
|
There was a problem hiding this comment.
Did this get auto-generated?
There was a problem hiding this comment.
It did after running the make compile-requirements command; otherwise, the CI was complaining.
The weird thing is that others were able to merge without this change.
From what I understand, this common_constraints.txt file is modified by the mentioned command, and based on the configuration defined here: https://github.com/openedx/edx-platform/blob/master/requirements/pip-tools.txt#L23
There was a problem hiding this comment.
I think it is good to merge now @ormsbee
484b0c0 to
68a3e90
Compare
68a3e90 to
8a4baf6
Compare
8a4baf6 to
c239653
Compare
This pulls in backup and restore changes from:
openedx/openedx-learning#448
It involves adding the missing author value when restoring a backup ZIP file.