Skip to content

feat: New states for library info icon in components in Unit page [FC-0114]#37735

Merged
ChrisChV merged 4 commits intoopenedx:masterfrom
open-craft:chris/FAL-4300-add-upstream-name
Dec 16, 2025
Merged

feat: New states for library info icon in components in Unit page [FC-0114]#37735
ChrisChV merged 4 commits intoopenedx:masterfrom
open-craft:chris/FAL-4300-add-upstream-name

Conversation

@ChrisChV
Copy link
Copy Markdown
Contributor

@ChrisChV ChrisChV commented Dec 8, 2025

Description

  • Adds upstream_name to the UpstreamLink dataclass.
  • Add new states to library info icon in components in Unit page
  • Which edX user roles will this change impact? "Developer".
image image image image

Supporting information

Testing instructions

  • In the unit page, add one component from a library.
  • Verify the new version of the library icon
  • Update and publish the component in the library
  • Refresh the unit page and verify the library icon in the ready-to-sync state.
  • Verify that you can open the sync modal by clicking the library icon.
  • Sync the component.
  • Make changes in the title of the component in the unit page.
  • Verify the library icon in the overrides state.
  • Delete the component in the library.
  • Refresh the unit page and verify the library icon in the broken state.
  • Follow the testing instructions in feat: New library sync icon [FC-0114] frontend-app-authoring#2739 to continue with the testing.

Deadline

None

Other information

N/A

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 8, 2025
@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented Dec 8, 2025

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Dec 8, 2025
@ChrisChV ChrisChV marked this pull request as draft December 8, 2025 22:32
@ChrisChV ChrisChV changed the title feat: upstream_name added to UpstreamLink dataclass feat: Add new states to library info icon in components in Unit page Dec 10, 2025
@ChrisChV ChrisChV changed the title feat: Add new states to library info icon in components in Unit page feat: New states for library info icon in components in Unit page Dec 10, 2025
@ChrisChV ChrisChV marked this pull request as ready for review December 10, 2025 01:35
Copy link
Copy Markdown
Contributor

@rpenido rpenido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your work @ChrisChV!

  • I tested this using the instructions from the PR
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Dec 11, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions Dec 11, 2025
@ChrisChV ChrisChV enabled auto-merge (squash) December 16, 2025 18:51
@ChrisChV ChrisChV changed the title feat: New states for library info icon in components in Unit page feat: New states for library info icon in components in Unit page [FC-0114] Dec 16, 2025
@ChrisChV ChrisChV merged commit a032955 into openedx:master Dec 16, 2025
64 checks passed
@ChrisChV ChrisChV deleted the chris/FAL-4300-add-upstream-name branch December 16, 2025 19:18
@github-project-automation github-project-automation Bot moved this from In Eng Review to Done in Contributions Dec 16, 2025
mraman-2U pushed a commit to mraman-2U/edx-platform that referenced this pull request Dec 24, 2025
…enedx#37735)

- Adds `upstream_name` to the `UpstreamLink` dataclass.
- Add new states to library info icon in components in Unit page
anfbermudezme pushed a commit to Pearson-Advance/edx-platform that referenced this pull request Feb 16, 2026
…enedx#37735)

- Adds `upstream_name` to the `UpstreamLink` dataclass.
- Add new states to library info icon in components in Unit page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants