Merged
Conversation
Make it so `make clean` doesn't blow away the venv folder. Given that this is managed by the developer, we should be able to manage its lifecycle independently. It was previously just in the list of files that comes by default from github's gitignore so it's not like we previously were of the opinion that we should delete this folder. Just that previously we had no opinion about it and now I think we should not delete it.
ormsbee
requested changes
Jan 14, 2026
Contributor
ormsbee
left a comment
ormsbee
left a comment
There was a problem hiding this comment.
I'm confused how this prevents cleaning the .venv/ folder. Isn't it just moving this line from one part of the .gitignore to another?
ormsbee
approved these changes
Jan 14, 2026
Contributor
ormsbee
left a comment
ormsbee
left a comment
There was a problem hiding this comment.
Oh, never mind, I didn't realize "noclean" existed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it so
make cleandoesn't blow away the venv folder. Given thatthis is managed by the developer, we should be able to manage its
lifecycle independently.
It was previously just in the list of files that comes by default from
github's gitignore so it's not like we previously were of the opinion
that we should delete this folder. Just that previously we had no
opinion about it and now I think we should not delete it.