feat!: Remove Unused Libraries v2 Import API & LTI Tool#38297
feat!: Remove Unused Libraries v2 Import API & LTI Tool#38297kdmccormick merged 6 commits intomasterfrom
Conversation
a98219f to
5e15768
Compare
5e15768 to
8a4e7d5
Compare
|
@arbrandes , I think you were a dev on the LTI_TOOL implementation, right? Can I get your take on whether it makes sense to remove it at this point? |
|
I'm actually surprised this is still here! I wasn't part of the migration from Blockstore, and it looks significantly different from what I remember. Which is to say: if this is not a desired feature, I certainly have no objections to it being removed. :) |
TODO more details
I believe this is because the M2M field ContentLibrary.authorized_lti_configs has been removed. That field was being queried in order to compute the `allow_lti` property when building a ContentLibraryMetadata object.
3e1b2c4 to
cad7c2d
Compare
|
@ormsbee @bradenmacdonald Could I get a review from one of you folks on this one? I think it's pretty straightforward, and it will make it easier for me to apply the openedx-core keys rework to openedx-platform next week. |
| # cms.djangoapps.export_course_metadata.tasks | ||
| # -> openedx.core.djangoapps.schedules.content_highlights | ||
| # -> lms.djangoapps.courseware.block_render & lms.djangoapps.courseware.model_data | ||
| "openedx.core.djangoapps.content_libraries.* -> lms.djangoapps.*.*", |
|
@kdmccormick Actually we developed the LTI integration for MIT, I believe - to embed library content into canvas. @pdpinch do you know if MIT is still using that? Was it really permanently disabled / impossible to enable? |
|
My understanding was that it LTI never worked in the post-blockstore library world. @arbrandes: Do I remember correctly that you had context on this? |
Description
This removes two content_libraries features which are unused. Both features were developed during the Blockstore Libraries days (~2021, back when Libraries V2 was pre-alpha). They were ostensibly ported during the Blockstore->Core transition but I don't think we ever tested them and I'd be surprised if they still work. I think we should remove them now in order to avoid having to bring them along through any more refactorings :)
The features:
Testing
When the sandbox comes up, I'll smoke test libraries, including the real Course Import feature (based on modulestore_migrator) to ensure it's not impacted.
Dev notes
The first commit was all a one-shot prompt to Sonnet 4.6:
I reviewed the whole diff afterwards. The rest of the commits are me cleaning it up.