Skip to content

fix: Date extensions tab still shows granted exentions even if reset#38394

Merged
wgu-taylor-payne merged 1 commit intoopenedx:masterfrom
WGU-Open-edX:bugfix/38393-filter-reset-extensions-from-granted-table
Apr 21, 2026
Merged

fix: Date extensions tab still shows granted exentions even if reset#38394
wgu-taylor-payne merged 1 commit intoopenedx:masterfrom
WGU-Open-edX:bugfix/38393-filter-reset-extensions-from-granted-table

Conversation

@brianjbuck-wgu
Copy link
Copy Markdown
Contributor

@brianjbuck-wgu brianjbuck-wgu commented Apr 20, 2026

Description

In the new Instructor Dashboard, when an instructor clicks "Reset Extensions" for a learner, the extension record remains visible in the "Granted Extensions" table on the Instructor Dashboard's Date Extensions tab. The table is intended to display only active extensions, but reset extensions still appear because the backend API returns them.

Fixes:

Other information

  • No database migrations required
  • No dependencies on other changes

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 20, 2026
@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented Apr 20, 2026

Thanks for the pull request, @brianjbuck-wgu!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Apr 20, 2026
@brianjbuck-wgu brianjbuck-wgu force-pushed the bugfix/38393-filter-reset-extensions-from-granted-table branch from 1dd5141 to 275da91 Compare April 20, 2026 17:05
@brianjbuck-wgu brianjbuck-wgu requested a review from Copilot April 20, 2026 17:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the instructor “Date Extensions” endpoint so that revoked/reset due date extensions no longer appear in the “Granted Extensions” list, aligning the backend results with the UI expectation from the linked issues.

Changes:

  • Filter out “reset” extensions in UnitExtensionsView.get_queryset when the override date is None or matches the original due date.
  • Add test coverage to ensure reset extensions are excluded while legitimate extensions remain visible.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
lms/djangoapps/instructor/views/api_v2.py Adds server-side filtering to remove reset/reverted overrides from the returned extension list.
lms/djangoapps/instructor/tests/test_api_v2.py Adds tests for reset-to-None, reset-to-original-date, and normal active extensions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lms/djangoapps/instructor/views/api_v2.py Outdated
Comment thread lms/djangoapps/instructor/views/api_v2.py Outdated
@brianjbuck-wgu brianjbuck-wgu force-pushed the bugfix/38393-filter-reset-extensions-from-granted-table branch from 275da91 to ceaee80 Compare April 20, 2026 17:29
@brianjbuck-wgu brianjbuck-wgu marked this pull request as ready for review April 20, 2026 17:58
Copy link
Copy Markdown
Contributor

@dwong2708 dwong2708 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good. Just a couple of suggestions

Comment thread lms/djangoapps/instructor/tests/test_api_v2.py
Comment thread lms/djangoapps/instructor/views/api_v2.py
Copy link
Copy Markdown
Contributor

@wgu-taylor-payne wgu-taylor-payne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I've left a couple of small comments. Is this something that should ultimately be moved into edx-when though? In that case we might want to 1) look at making those changes or 2) adding an issue on edx-when and leaving a comment with the issue number where we do this filtering.

Comment thread lms/djangoapps/instructor/tests/test_api_v2.py Outdated
Comment thread lms/djangoapps/instructor/tests/test_api_v2.py Outdated
@brianjbuck-wgu
Copy link
Copy Markdown
Contributor Author

@wgu-taylor-payne, I did consider making the upstream change to edx-when, but I am not sure what the downstream affects would be especially this close to the cutoff for the verawood release.

@wgu-taylor-payne
Copy link
Copy Markdown
Contributor

@wgu-taylor-payne, I did consider making the upstream change to edx-when, but I am not sure what the downstream affects would be especially this close to the cutoff for the verawood release.

Yeah, that makes sense. Could you at least bring this up in an issue on edx-when so it can be investigated further at some point?

@diana-villalvazo-wgu
Copy link
Copy Markdown
Contributor

tested on UI and works as expected 👍

@brianjbuck-wgu
Copy link
Copy Markdown
Contributor Author

recheck

Previous commits:
- fix: Date extensions tab still shows granted exentions even if reset
- fix: Address Copilot feedback
- fix: PR feedback
- fix: Add TODO comment with link to edx-when repo issue
@brianjbuck-wgu brianjbuck-wgu force-pushed the bugfix/38393-filter-reset-extensions-from-granted-table branch from 2f74d0a to 06b2dc1 Compare April 21, 2026 20:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wgu-taylor-payne wgu-taylor-payne merged commit eb85705 into openedx:master Apr 21, 2026
55 of 61 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Apr 21, 2026
@diana-villalvazo-wgu diana-villalvazo-wgu deleted the bugfix/38393-filter-reset-extensions-from-granted-table branch April 21, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants